-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11781. Implement Dynamic Requests Handling in CapacityScheduler #7448
base: trunk
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
try { | ||
reinitRequestsHandler(this.conf); | ||
} catch (Throwable innerT) { | ||
LOG.error("Failed to re-init requests handler : {}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the basic functions be affected if the initialization fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zeekling for the review.
oldConf is a configuration that has already been validated and is in effect, the invocation of CapacityScheduler#reinitRequestsHandler here will not throw an exception actually. The purpose of this try/catch block is only included to make sure that the original rollback logic remains unaffected.
Description of PR
Details:
Usage: To enable and configure the request handler, administrators can set the following properties in capacity-scheduler.xml:
yarn.scheduler.capacity.request-handler.enabled: Enables or disables the request handler.
yarn.scheduler.capacity.request-handler.updates: Specifies the JSON configuration for the request updates.
Configuration example:
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?